deniskuzZ commented on code in PR #5323:
URL: https://github.com/apache/hive/pull/5323#discussion_r1686027205
##########
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFMkCollectionEvaluator.java:
##########
@@ -61,23 +61,19 @@ public ObjectInspector init(Mode m, ObjectInspector[]
parameters)
throws HiveException {
super.init(m, parameters);
// init output object inspectors
- // The output of a partial aggregation is a list
- if (m == Mode.PARTIAL1) {
+ // Mode.PARTIAL1 or Mode.COMPLETE: T => List[T]
+ // Mode.PARTIAL2 or Mode.FINAL: List[T] => List[T]
+ // The output of a partial aggregation is a list, output of COMPLETE is
List as well
Review Comment:
could we please inline the comments
````
if (mode == Mode.PARTIAL1 || mode == Mode.COMPLETE) {
// T => List[T]
inputOI = parameters[0];
return ObjectInspectorFactory.getStandardListObjectInspector(
ObjectInspectorUtils.getStandardObjectInspector(inputOI));
} else {
// List[T] => List[T]
....
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
