SourabhBadhya commented on code in PR #5254:
URL: https://github.com/apache/hive/pull/5254#discussion_r1686390321
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -2112,4 +2124,12 @@ public List<FileStatus>
getMergeTaskInputFiles(Properties properties) throws IOE
public MergeTaskProperties getMergeTaskProperties(Properties properties) {
return new IcebergMergeTaskProperties(properties);
}
+
+ @Override
+ public void setCustomDeleteProperties(TableDesc tableDesc) {
+ tableDesc.getProperties().put(InputFormatConfig.OPERATION_TYPE_PREFIX +
tableDesc.getTableName(),
+ Operation.DELETE.name());
+
tableDesc.getProperties().put(HiveCustomStorageHandlerUtils.WRITE_OPERATION_CONFIG_PREFIX
+
Review Comment:
Added util methods in TableDesc to get and set property.
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergAcidUtil.java:
##########
@@ -49,8 +56,14 @@ private IcebergAcidUtil() {
private static final Map<Types.NestedField, Integer> FILE_READ_META_COLS =
Maps.newLinkedHashMap();
private static final Map<String, Types.NestedField>
VIRTUAL_COLS_TO_META_COLS = Maps.newLinkedHashMap();
public static final String META_TABLE_PROPERTY = "metaTable";
+ private static final Map<Types.NestedField, Integer> DELETE_FILE_META_COLS =
Maps.newLinkedHashMap();
+ public static final Integer PARTITION_PROJECTION_COLUMN_ID =
Integer.MAX_VALUE - 6;
+ private static final String PARTITION_PROJECTION_COLUMN_NAME =
"partition_projection";
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
