BsoBird commented on PR #5349: URL: https://github.com/apache/hive/pull/5349#issuecomment-2245468748
> build failed with indentation checks - checkstyle stuff > > as for tests, can't we also move them to patched modules as well? Sir, it's difficult to test this class directly in the HIVE code because of the special compilation method we use to integrate the patch into HIVE. But let me try. I'll also fix the checkstyle related problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
