difin commented on code in PR #5328:
URL: https://github.com/apache/hive/pull/5328#discussion_r1688471744
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/compact/AlterTableCompactOperation.java:
##########
@@ -89,7 +90,8 @@ public AlterTableCompactOperation(DDLOperationContext
context, AlterTableCompact
}
//Will directly initiate compaction if an un-partitioned table/a partition
is specified in the request
- if (desc.getPartitionSpec() != null || !table.isPartitioned()) {
+ if (desc.getPartitionSpec() != null || (!table.isPartitioned() &&
!DDLUtils.isIcebergTable(table) ) ||
Review Comment:
I don't think it can be simplified like that..
Since `org.apache.hadoop.hive.ql.metadata.table.isPartitioned()` will always
return false for Iceberg tables, it is not a suitable check for Iceberg, so I
am checking `(!table.isPartitioned() && !DDLUtils.isIcebergTable(table))`,
which check that the table is unpartitioned and is not Iceberg.
In another part of the condition I am checking if the table is Iceberg and
if it is unpartitioned:
`(DDLUtils.isIcebergTable(table) &&
!table.getStorageHandler().isPartitioned(table))`
I think we have to check if the table is Iceberg because for native tables
table.getStorageHandler() will be null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
