KiranVelumuri commented on PR #5327: URL: https://github.com/apache/hive/pull/5327#issuecomment-2255413580
> The description of [HIVE-28355](https://issues.apache.org/jira/browse/HIVE-28355) is super great. Thanks for the detailed explanation. This change would resolve the problem. > > For reference, I am putting alternatives that came to my mind. I don't have preference and the current PR looks fine to me. > > * Just to remove the non-deterministic test case > * To change the expected text to `{System.currentTimeMillis()/10000}|{System.currentTimeMillis()/10000 + 1}` > * Control the output using `hive.test.currenttimestamp` Thank you for the quick review. The first alternative would not work as the test result depends on the time of execution of test. For the latter one, the test would fail when the timestamp differs other than ten's digit. Could you please tag a committer to get +1? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
