tanishq-chugh commented on code in PR #5385:
URL: https://github.com/apache/hive/pull/5385#discussion_r1706767575
##########
pom.xml:
##########
@@ -126,10 +126,10 @@
<commons-configuration.version>1.10</commons-configuration.version>
<commons-exec.version>1.1</commons-exec.version>
<commons-io.version>2.12.0</commons-io.version>
- <commons-pool2.version>2.11.1</commons-pool2.version>
+ <commons-pool2.version>2.12.0</commons-pool2.version>
Review Comment:
commons-pool2 was defined in ql module in the same PR where it was declared
explicitly - [PR-3472](https://github.com/apache/hive/pull/3472) . But, i
believe that would be because mentioning in dependency-management in root pom
would only make sure that version of commons-pool2 coming in transitively is
kept consistent and not explicitly make commons-pool2 as direct dependency of
hive which was required then.
But even i am not very sure that why was it declared only in ql and not
other modules such as standalone-metastore where commons-dbcp2 is being pulled
in.
Could be because the intention was to ensure commons-pool2 jar is in the
complete hive package to prevent any potential runtime issues & having it in ql
module would be sufficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
