dengzhhu653 commented on code in PR #5362:
URL: https://github.com/apache/hive/pull/5362#discussion_r1719210401
##########
jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java:
##########
@@ -130,22 +126,20 @@ public class HiveStatement implements java.sql.Statement {
public HiveStatement(HiveConnection connection, TCLIService.Iface client,
TSessionHandle sessHandle) {
- this(connection, client, sessHandle, false, 0, DEFAULT_FETCH_SIZE);
+ this(connection, client, sessHandle, false, connection.fetchSize);
}
public HiveStatement(HiveConnection connection, TCLIService.Iface client,
TSessionHandle sessHandle,
- boolean isScrollableResultset, int initFetchSize, int defaultFetchSize) {
+ boolean isScrollableResultset, int fetchSize) {
Review Comment:
It shouldn't as I know, the original constructor is introduced since Hive
4.0, the HiveConnection and HiveStatement are in a single jar, so they are
supposed to be loaded together by the same class loader, I'm not sure how the
old `HiveConnection` can point to the new `HiveStatement` in the runtime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
