dengzhhu653 commented on code in PR #5398:
URL: https://github.com/apache/hive/pull/5398#discussion_r1723502826
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/DirectSqlUpdatePart.java:
##########
@@ -526,18 +519,18 @@ public Map<String, Map<String, String>>
updatePartitionColumnStatistics(Map<Stri
MetaStoreListenerNotifier.notifyEventWithDirectSql(transactionalListeners,
EventMessage.EventType.UPDATE_PARTITION_COLUMN_STAT_BATCH,
eventBatch, dbConn, sqlGenerator);
}
- dbConn.commit();
- committed = true;
+ closeDbConn(jdoConn);
Review Comment:
this won't close the underlying connection because the current active is
active, see
https://github.com/datanucleus/datanucleus-core/blob/efba3bd0e8345e1171d5fe529cae693293f178ae/src/main/java/org/datanucleus/store/AbstractStoreManager.java#L378-L392
It tells we have reached the end of `transaction` and is able to commit now,
until the `tx.commit()` the underlying connection will return back to the
connection pool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
