dengzhhu653 commented on code in PR #5398:
URL: https://github.com/apache/hive/pull/5398#discussion_r1728041850
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/DirectSqlUpdatePart.java:
##########
@@ -484,14 +477,14 @@ public Map<String, Map<String, String>>
updatePartitionColumnStatistics(Map<Stri
String validWriteIds,
long writeId,
List<TransactionalMetaStoreEventListener> transactionalListeners)
throws MetaException {
+
JDOConnection jdoConn = null;
- Connection dbConn = null;
- boolean committed = false;
+ Transaction tx = pm.currentTransaction();
Review Comment:
It's used to mark we have opened a transaction explicitly, when `jdoConn =
pm.getDataStoreConnection()`, it will get the connection from the primary
connection pool,
https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PersistenceManagerProvider.java#L307
https://github.com/datanucleus/datanucleus-core/blob/master/src/main/java/org/datanucleus/store/AbstractStoreManager.java#L373
https://github.com/datanucleus/datanucleus-core/blob/master/src/main/java/org/datanucleus/store/connection/ConnectionManager.java#L92
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
