deniskuzZ commented on code in PR #5404:
URL: https://github.com/apache/hive/pull/5404#discussion_r1728527234
##########
common/src/java/org/apache/hadoop/hive/ant/GenHiveTemplate.java:
##########
@@ -73,21 +73,23 @@ private Document generateTemplate() throws Exception {
doc.appendChild(doc.createProcessingInstruction(
"xml-stylesheet", "type=\"text/xsl\" href=\"configuration.xsl\""));
- doc.appendChild(doc.createComment("\n" +
- " Licensed to the Apache Software Foundation (ASF) under one or
more\n" +
- " contributor license agreements. See the NOTICE file distributed
with\n" +
- " this work for additional information regarding copyright
ownership.\n" +
- " The ASF licenses this file to You under the Apache License,
Version 2.0\n" +
- " (the \"License\"); you may not use this file except in compliance
with\n" +
- " the License. You may obtain a copy of the License at\n" +
- "\n" +
- " http://www.apache.org/licenses/LICENSE-2.0\n"; +
- "\n" +
- " Unless required by applicable law or agreed to in writing,
software\n" +
- " distributed under the License is distributed on an \"AS IS\"
BASIS,\n" +
- " WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
implied.\n" +
- " See the License for the specific language governing permissions
and\n" +
- " limitations under the License.\n"));
+ doc.appendChild(doc.createComment("""
Review Comment:
why did we strip new lines?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
