himanshu-mishra opened a new pull request, #5406:
URL: https://github.com/apache/hive/pull/5406
… in previous RS
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA:
https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
As SMB replaces last RS op from the joining branches and the JOIN op with
MERGEJOIN, we need to ensure the RS before these RS, in both branches, are
partitioning using same hash generator.
Hash code generator differs based on ReducerTraits.UNIFORM i.e.
ReduceSinkOperator#computeMurmurHash() or
ReduceSinkOperator#computeHashCode(), leading to different hash code for same
value.
Skip SMB join in such cases.
### Why are the changes needed?
It fixes bug that results in incorrect join result. Example query and
behavior explanation is added in
https://issues.apache.org/jira/browse/HIVE-28480
### Does this PR introduce _any_ user-facing change?
No
### Is the change a dependency upgrade?
No
### How was this patch tested?
Tested via `auto_sortmerge_join_18.q` added in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
