difin commented on code in PR #5399:
URL: https://github.com/apache/hive/pull/5399#discussion_r1731724273
##########
service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java:
##########
@@ -160,7 +158,7 @@
// If the cookie based authentication is already enabled, parse the
// request and validate the request cookies.
if (isCookieAuthEnabled) {
- clientUserName = validateCookie(request);
+ clientUserName = httpAuthService.validateCookie(request);
Review Comment:
This is existing functionality ThriftHttpServlet which I didn't change in
this PR.
##########
service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java:
##########
@@ -257,10 +255,10 @@
if (requireNewCookie &&
!authType.isEnabled(HiveAuthConstants.AuthTypes.NOSASL)) {
String cookieToken = HttpAuthUtils.createCookieToken(clientUserName);
- Cookie hs2Cookie = createCookie(signer.signCookie(cookieToken));
+ Cookie hs2Cookie = httpAuthService.signAndcreateCookie(cookieToken);
Review Comment:
This is existing functionality ThriftHttpServlet which I didn't change in
this PR.
##########
service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java:
##########
@@ -537,14 +409,14 @@
*/
private String doPasswdAuth(HttpServletRequest request, String authType)
throws HttpAuthenticationException {
- String userName = getUsername(request);
+ String userName = httpAuthService.getUsername(request);
Review Comment:
This is existing functionality ThriftHttpServlet which I didn't change in
this PR.
##########
service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java:
##########
@@ -577,7 +449,7 @@
throws HttpAuthenticationException {
// Each http request must have an Authorization header
// Check before trying to do kerberos authentication twice
- getAuthHeader(request);
+ httpAuthService.getAuthHeader(request);
Review Comment:
This is existing functionality ThriftHttpServlet which I didn't change in
this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
