okumin commented on code in PR #5404:
URL: https://github.com/apache/hive/pull/5404#discussion_r1734810415


##########
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFDateFormat.java:
##########
@@ -166,7 +166,7 @@ public void testNullFmt() throws HiveException {
   public void testWrongFmt() throws HiveException {
     GenericUDFDateFormat udf = new GenericUDFDateFormat();
     ObjectInspector valueOI0 = 
PrimitiveObjectInspectorFactory.writableStringObjectInspector;
-    Text fmtText = new Text("B");
+    Text fmtText = new Text("C");                                              
                         // 'B' is defined as a pattern in jdk17 to represent 
period-of-day, changing it to pattern 'C' having no definition in jdk17

Review Comment:
   Interesting. You may remove extra spaces



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to