deniskuzZ commented on code in PR #5417:
URL: https://github.com/apache/hive/pull/5417#discussion_r1735971145


##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java:
##########
@@ -1646,7 +1646,7 @@ private static Set<Operator<?>> 
gatherDPPBranchOps(ParseContext pctx,
   }
 
   private static void removeBranch(Operator<?> currentOp, Set<Operator<?>> 
branchesOps,
-          Set<Operator<?>> discardableOps) {
+          SharedWorkOptimizerCache optimizerCache, Set<Operator<?>> 
discardableOps) {

Review Comment:
   could we move the cache to the last param?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to