deniskuzZ commented on code in PR #5409: URL: https://github.com/apache/hive/pull/5409#discussion_r1736004926
########## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergSplit.java: ########## @@ -88,6 +94,25 @@ public byte[] getBytesForHash() { } } + @Override + public OptionalInt getBucketHashCode() { + final StructLike key = innerSplit.task().groupingKey(); + if (key.size() == 0) { + return OptionalInt.empty(); + } + final int numBucketKeys = key.size(); Review Comment: could be simplified to ```` int[] bucketIds = IntStream.range(0, key.size()).map(i -> key.get(i, Integer.class)).toArray(); ```` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org