okumin commented on code in PR #5409:
URL: https://github.com/apache/hive/pull/5409#discussion_r1740240215
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergSplit.java:
##########
@@ -75,7 +81,7 @@ public Path getPath() {
@Override
public byte[] getBytesForHash() {
- Collection<FileScanTask> fileScanTasks = innerSplit.task().files();
+ Collection<FileScanTask> fileScanTasks = innerSplit.task().tasks();
Review Comment:
Because only `CombinedScanTask` has `tasks`. As far as I read the source
code, `CombinedScanTask#tasks` and `CombinedScanTask#files` are likely to
return the same list.
Renamed `IcebergSplit#task`
https://github.com/apache/hive/pull/5409/commits/3c57a67327340197c2f1798503ab1927a5104cdd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
