deniskuzZ commented on code in PR #5418:
URL: https://github.com/apache/hive/pull/5418#discussion_r1741899159
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/writer/HiveIcebergWriterBase.java:
##########
@@ -77,4 +86,39 @@ protected PartitionKey partition(Record row, int specId) {
partitionKey.partition(wrapper.wrap(row));
return partitionKey;
}
+
+ // use a fanout writer only if enabled and the input is unordered and the
table is partitioned
+ static PartitioningWriter<Record, DataWriteResult> newDataWriter(
+ Table table, HiveFileWriterFactory writers, OutputFileFactory files,
Context context) {
+
+ FileIO io = table.io();
+ boolean useFanoutWriter = context.useFanoutWriter();
+ long targetFileSize = context.targetDataFileSize();
+
+ if (table.spec().isPartitioned() && useFanoutWriter) {
Review Comment:
yes, see SparkPositionDeltaWrite
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
