InvisibleProgrammer commented on PR #5432: URL: https://github.com/apache/hive/pull/5432#issuecomment-2328048238
Hi, For the first sight it looks good. But it opens some questions: What is the current behaviour if the call cannot be committed? Is the method throws an exception? After that change, in case it have to be rolled back, from the caller's standpoint, it looks like a successful call: I call the method, no errors given, no return value. So I assume the call was successful. Shouldn't we throw at least a meta exception (if we don't want a breaking change) or modify the interface to return with a true/false value that tells if the call was successful (like in `alterDatabase`)? Also, can you add a test for a change? `TestObjectStoreSchemaMethods` can be a proper place to do that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
