abstractdog commented on code in PR #5399: URL: https://github.com/apache/hive/pull/5399#discussion_r1745333948
########## service/src/test/org/apache/hive/service/server/TestHS2HttpServerLDAP.java: ########## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hive.service.server; + +import org.apache.hadoop.hive.conf.HiveConf; +import org.apache.hadoop.hive.conf.HiveConf.ConfVars; +import org.apache.hadoop.hive.metastore.MetaStoreTestUtils; +import org.apache.hive.service.auth.HttpAuthService; +import org.apache.hive.service.auth.HttpAuthUtils; +import org.apache.hive.service.auth.PasswdAuthenticationProvider; +import org.apache.hive.service.auth.ldap.LdapAuthService; +import org.apache.http.client.methods.HttpGet; +import org.apache.http.client.methods.HttpPost; +import org.apache.http.client.CookieStore; +import org.apache.http.cookie.Cookie; +import org.apache.http.impl.client.BasicCookieStore; +import org.apache.http.impl.client.CloseableHttpClient; +import org.apache.http.impl.client.HttpClientBuilder; +import org.apache.http.impl.client.HttpClients; +import org.apache.http.params.BasicHttpParams; +import org.apache.http.params.HttpParams; +import org.eclipse.jetty.http.HttpHeader; +import org.eclipse.jetty.util.B64Code; +import org.eclipse.jetty.util.StringUtil; +import java.util.List; +import java.util.Optional; +import org.junit.AfterClass; +import org.junit.Assert; +import org.junit.BeforeClass; +import org.junit.Test; + +import javax.security.sasl.AuthenticationException; + +public class TestHS2HttpServerLDAP { + + private static HiveServer2 hiveServer2; + private static Integer webUIPort; + private static final String HOST = "localhost"; + private static String metastorePasswd = "693efe9fa425ad21886d73a0fa3fbc70"; //random md5 + private static final String VALID_USER = "validUser"; + private static final String VALID_PASS = "validPass"; + private static final String INVALID_USER = "invalidUser"; + private static final String INVALID_PASS = "invalidPass"; + + @BeforeClass + public static void beforeTests() throws Exception { + webUIPort = + MetaStoreTestUtils.findFreePortExcepting(Integer.parseInt(ConfVars.HIVE_SERVER2_WEBUI_PORT.getDefaultValue())); + HiveConf hiveConf = new HiveConf(); + hiveConf.setBoolVar(ConfVars.HIVE_IN_TEST, true); + hiveConf.set(ConfVars.HIVE_SERVER2_WEBUI_PORT.varname, webUIPort.toString()); + hiveConf.setBoolVar(ConfVars.HIVE_SERVER2_WEBUI_ENABLE_LDAP, true); + hiveConf.set(ConfVars.METASTORE_PWD.varname, metastorePasswd); + hiveConf.setVar(HiveConf.ConfVars.HIVE_AUTHORIZATION_MANAGER, + "org.apache.hadoop.hive.ql.security.authorization.plugin.sqlstd.SQLStdHiveAuthorizerFactory"); + PasswdAuthenticationProvider authenticationProvider = new DummyLdapAuthenticationProviderImpl(); + hiveServer2 = new HiveServer2(authenticationProvider); + hiveServer2.init(hiveConf); + hiveServer2.start(); + Thread.sleep(5000); + } + + @Test + public void testValidCredentialsWithAuthorizationHeader() throws Exception { + CloseableHttpClient httpclient = null; + try { + CookieStore httpCookieStore = new BasicCookieStore(); + HttpClientBuilder builder = HttpClientBuilder.create().setDefaultCookieStore(httpCookieStore); + httpclient = builder.build(); + + HttpGet httpGet = new HttpGet("http://"; + HOST + ":" + webUIPort + "/jmx"); + String authB64Code = B64Code.encode(VALID_USER + ":" + VALID_PASS, StringUtil.__ISO_8859_1); + httpGet.setHeader(HttpHeader.AUTHORIZATION.asString(), "Basic " + authB64Code); + httpclient.execute(httpGet); + + Assert.assertTrue(isAuthorized(httpCookieStore.getCookies())); + } finally { + if (httpclient != null) { + httpclient.close(); + } + } + } + + @Test + public void testInvalidCredentiaWithInAuthorizationHeader() throws Exception { + CloseableHttpClient httpclient = null; + try { + CookieStore httpCookieStore = new BasicCookieStore(); + HttpClientBuilder builder = HttpClientBuilder.create().setDefaultCookieStore(httpCookieStore); + httpclient = builder.build(); + httpclient = HttpClients.createDefault(); + + HttpGet httpGet = new HttpGet("http://"; + HOST + ":" + webUIPort + "/jmx"); + String authB64Code = B64Code.encode(INVALID_USER + ":" + INVALID_PASS, StringUtil.__ISO_8859_1); + httpGet.setHeader(HttpHeader.AUTHORIZATION.asString(), "Basic " + authB64Code); + httpclient.execute(httpGet); + + Assert.assertFalse(isAuthorized(httpCookieStore.getCookies())); + } finally { + if (httpclient != null) { + httpclient.close(); + } + } + } + + @Test + public void testValidCredentialsWithRequestParameters() throws Exception { + CloseableHttpClient httpclient = null; + try { + CookieStore httpCookieStore = new BasicCookieStore(); + HttpClientBuilder builder = HttpClientBuilder.create().setDefaultCookieStore(httpCookieStore); + httpclient = builder.build(); + + httpclient = HttpClients.createDefault(); + HttpParams params = new BasicHttpParams(); + params.setParameter(HttpAuthService.USERNAME_REQUEST_PARAM_NAME, VALID_USER); + params.setParameter(HttpAuthService.PASSWORD_REQUEST_PARAM_NAME, VALID_PASS); + + HttpPost httpPost = new HttpPost("http://"; + HOST + ":" + webUIPort + "/login"); + httpPost.setParams(params); + httpclient.execute(httpPost); + + Assert.assertFalse(isAuthorized(httpCookieStore.getCookies())); + } finally { + if (httpclient != null) { + httpclient.close(); + } + } + } + + @Test + public void testInvalidCredentialsWithRequestParameters() throws Exception { + CloseableHttpClient httpclient = null; + try { + CookieStore httpCookieStore = new BasicCookieStore(); + HttpClientBuilder builder = HttpClientBuilder.create().setDefaultCookieStore(httpCookieStore); + httpclient = builder.build(); Review Comment: duplicated assignment: ``` httpclient = builder.build(); ``` vs. ``` httpclient = HttpClients.createDefault(); ``` ########## service/src/test/org/apache/hive/service/server/TestHS2HttpServerLDAP.java: ########## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hive.service.server; + +import org.apache.hadoop.hive.conf.HiveConf; +import org.apache.hadoop.hive.conf.HiveConf.ConfVars; +import org.apache.hadoop.hive.metastore.MetaStoreTestUtils; +import org.apache.hive.service.auth.HttpAuthService; +import org.apache.hive.service.auth.HttpAuthUtils; +import org.apache.hive.service.auth.PasswdAuthenticationProvider; +import org.apache.hive.service.auth.ldap.LdapAuthService; +import org.apache.http.client.methods.HttpGet; +import org.apache.http.client.methods.HttpPost; +import org.apache.http.client.CookieStore; +import org.apache.http.cookie.Cookie; +import org.apache.http.impl.client.BasicCookieStore; +import org.apache.http.impl.client.CloseableHttpClient; +import org.apache.http.impl.client.HttpClientBuilder; +import org.apache.http.impl.client.HttpClients; +import org.apache.http.params.BasicHttpParams; +import org.apache.http.params.HttpParams; +import org.eclipse.jetty.http.HttpHeader; +import org.eclipse.jetty.util.B64Code; +import org.eclipse.jetty.util.StringUtil; +import java.util.List; +import java.util.Optional; +import org.junit.AfterClass; +import org.junit.Assert; +import org.junit.BeforeClass; +import org.junit.Test; + +import javax.security.sasl.AuthenticationException; + +public class TestHS2HttpServerLDAP { + + private static HiveServer2 hiveServer2; + private static Integer webUIPort; + private static final String HOST = "localhost"; + private static String metastorePasswd = "693efe9fa425ad21886d73a0fa3fbc70"; //random md5 + private static final String VALID_USER = "validUser"; + private static final String VALID_PASS = "validPass"; + private static final String INVALID_USER = "invalidUser"; + private static final String INVALID_PASS = "invalidPass"; + + @BeforeClass + public static void beforeTests() throws Exception { + webUIPort = + MetaStoreTestUtils.findFreePortExcepting(Integer.parseInt(ConfVars.HIVE_SERVER2_WEBUI_PORT.getDefaultValue())); + HiveConf hiveConf = new HiveConf(); + hiveConf.setBoolVar(ConfVars.HIVE_IN_TEST, true); + hiveConf.set(ConfVars.HIVE_SERVER2_WEBUI_PORT.varname, webUIPort.toString()); + hiveConf.setBoolVar(ConfVars.HIVE_SERVER2_WEBUI_ENABLE_LDAP, true); + hiveConf.set(ConfVars.METASTORE_PWD.varname, metastorePasswd); + hiveConf.setVar(HiveConf.ConfVars.HIVE_AUTHORIZATION_MANAGER, + "org.apache.hadoop.hive.ql.security.authorization.plugin.sqlstd.SQLStdHiveAuthorizerFactory"); + PasswdAuthenticationProvider authenticationProvider = new DummyLdapAuthenticationProviderImpl(); + hiveServer2 = new HiveServer2(authenticationProvider); + hiveServer2.init(hiveConf); + hiveServer2.start(); + Thread.sleep(5000); + } + + @Test + public void testValidCredentialsWithAuthorizationHeader() throws Exception { + CloseableHttpClient httpclient = null; + try { + CookieStore httpCookieStore = new BasicCookieStore(); + HttpClientBuilder builder = HttpClientBuilder.create().setDefaultCookieStore(httpCookieStore); + httpclient = builder.build(); + + HttpGet httpGet = new HttpGet("http://"; + HOST + ":" + webUIPort + "/jmx"); + String authB64Code = B64Code.encode(VALID_USER + ":" + VALID_PASS, StringUtil.__ISO_8859_1); + httpGet.setHeader(HttpHeader.AUTHORIZATION.asString(), "Basic " + authB64Code); + httpclient.execute(httpGet); + + Assert.assertTrue(isAuthorized(httpCookieStore.getCookies())); + } finally { + if (httpclient != null) { + httpclient.close(); + } + } + } + + @Test + public void testInvalidCredentiaWithInAuthorizationHeader() throws Exception { + CloseableHttpClient httpclient = null; + try { + CookieStore httpCookieStore = new BasicCookieStore(); + HttpClientBuilder builder = HttpClientBuilder.create().setDefaultCookieStore(httpCookieStore); + httpclient = builder.build(); + httpclient = HttpClients.createDefault(); + + HttpGet httpGet = new HttpGet("http://"; + HOST + ":" + webUIPort + "/jmx"); + String authB64Code = B64Code.encode(INVALID_USER + ":" + INVALID_PASS, StringUtil.__ISO_8859_1); + httpGet.setHeader(HttpHeader.AUTHORIZATION.asString(), "Basic " + authB64Code); + httpclient.execute(httpGet); + + Assert.assertFalse(isAuthorized(httpCookieStore.getCookies())); + } finally { + if (httpclient != null) { + httpclient.close(); + } + } + } + + @Test + public void testValidCredentialsWithRequestParameters() throws Exception { + CloseableHttpClient httpclient = null; + try { + CookieStore httpCookieStore = new BasicCookieStore(); + HttpClientBuilder builder = HttpClientBuilder.create().setDefaultCookieStore(httpCookieStore); + httpclient = builder.build(); + + httpclient = HttpClients.createDefault(); + HttpParams params = new BasicHttpParams(); + params.setParameter(HttpAuthService.USERNAME_REQUEST_PARAM_NAME, VALID_USER); + params.setParameter(HttpAuthService.PASSWORD_REQUEST_PARAM_NAME, VALID_PASS); + + HttpPost httpPost = new HttpPost("http://"; + HOST + ":" + webUIPort + "/login"); + httpPost.setParams(params); + httpclient.execute(httpPost); + + Assert.assertFalse(isAuthorized(httpCookieStore.getCookies())); + } finally { + if (httpclient != null) { + httpclient.close(); + } + } + } + + @Test + public void testInvalidCredentialsWithRequestParameters() throws Exception { + CloseableHttpClient httpclient = null; + try { + CookieStore httpCookieStore = new BasicCookieStore(); + HttpClientBuilder builder = HttpClientBuilder.create().setDefaultCookieStore(httpCookieStore); + httpclient = builder.build(); Review Comment: duplicated assignment: ``` httpclient = builder.build(); ``` vs. ``` httpclient = HttpClients.createDefault(); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
