difin commented on code in PR #5399:
URL: https://github.com/apache/hive/pull/5399#discussion_r1746279795
##########
service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java:
##########
@@ -143,6 +140,7 @@ public ThriftHttpServlet(TProcessor processor,
TProtocolFactory protocolFactory,
if (this.authType.isEnabled(HiveAuthConstants.AuthTypes.JWT)) {
this.jwtValidator = new JWTValidator(hiveConf);
}
+ this.httpAuthService = new HttpAuthService(cookieDomain, cookiePath,
cookieMaxAge, isCookieSecure, AUTH_COOKIE);
Review Comment:
ThriftHttpServlet and LdapAuthService both instantiate HttpAuthService with
a their own cookie values.
I think it is ok to leave cookie values for ThriftHttpServlet in
ThriftHttpServlet?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
