abstractdog commented on PR #4882:
URL: https://github.com/apache/hive/pull/4882#issuecomment-2333993183
> Is the credentials fix - the one Kokila pointed out going in before
further merge? Otherwise looks good
yes, tried to clarify this in code comments, but let me add links here for
more clarity:
```
* Regarding vertex user: LlapTaskCommunicator has a single "user" field,
* which is passed into the SignableVertexSpec.
```
https://github.com/apache/hive/blob/e0bd9eac32851b27976a78cd83584cb867b83182/llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java#L125
https://github.com/apache/hive/blob/e0bd9eac32851b27976a78cd83584cb867b83182/llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java#L919
```
* Regarding credentials: LlapTaskCommunicator creates
SubmitWorkRequestProto instances,
* into which dag-level credentials are passed.
```
https://github.com/apache/hive/blob/e0bd9eac32851b27976a78cd83584cb867b83182/llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java#L918
so assuming that the user is constant and credentials are DAG-level ones, we
can make sure that the UserGroupInformation and the contained Credentials are
not supposed to change withing a dag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
