difin commented on code in PR #5399:
URL: https://github.com/apache/hive/pull/5399#discussion_r1747272788
##########
service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java:
##########
@@ -289,7 +287,7 @@ protected void doPost(HttpServletRequest request,
HttpServletResponse response)
} else {
try {
LOG.error("Login attempt is failed for user : " +
- getUsername(request) + ". Error Messsage :" + e.getMessage());
+ httpAuthService.getUsername(request) + ". Error Messsage :" +
e.getMessage());
} catch (Exception ex) {
// Ignore Exception
Review Comment:
With this change that I did of throwing an exception in this place a few
unit tests started to fail.
In this place, the exception used to be ignored in case its logging had
failed.
In any case, the response status is set properly to reflect an error
`response.setStatus(HttpServletResponse.SC_UNAUTHORIZED);`
I reverted throwing of the exception and instead improved the comment with
explanation of why it's ignored.
Do you find it's ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
