zhangbutao commented on PR #5434: URL: https://github.com/apache/hive/pull/5434#issuecomment-2344003134
Looks good! Need to rebase to fix the conflicts. BTW, I think if we can do checkstyle in the ci pipeline, then we will avoid lots of similar code style issue. But hive never use the checkstyle except the hive-iceberg handler module. :( see HIVE-28499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
