abstractdog commented on code in PR #4882:
URL: https://github.com/apache/hive/pull/4882#discussion_r1759063702
##########
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java:
##########
@@ -292,7 +292,8 @@ public SubmitWorkResponseProto
submitWork(SubmitWorkRequestProto request) throws
// Lazy create conf object, as it gets expensive in this codepath.
Supplier<Configuration> callableConf = () -> new
Configuration(getConfig());
- UserGroupInformation fsTaskUgi = fsUgiFactory == null ? null :
fsUgiFactory.createUgi();
+ UserGroupInformation fsTaskUgi =
+ fsUgiFactory.createUgi(queryIdentifier.toShortString(),
vertex.getUser(), credentials);
Review Comment:
no, we create one or fail:
```
UgiFactory fsUgiFactory = null;
try {
fsUgiFactory = LlapUgiFactoryFactory.createFsUgiFactory(daemonConf);
} catch (IOException e) {
throw new RuntimeException(e);
}
```
in createFsUgiFactory:
```
return hasFsKeytab ? new KerberosUgiFactory(fsKeytab, fsPrincipal) : new
NoopUgiFactory();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
