deniskuzZ commented on code in PR #4882:
URL: https://github.com/apache/hive/pull/4882#discussion_r1759266139
##########
llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapUgiFactoryFactory.java:
##########
@@ -15,42 +15,115 @@
package org.apache.hadoop.hive.llap.security;
import java.io.IOException;
+import java.util.Map;
+import java.util.HashMap;
import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FileSystem;
import org.apache.hadoop.hive.common.UgiFactory;
import org.apache.hadoop.hive.conf.HiveConf;
import org.apache.hadoop.hive.conf.HiveConf.ConfVars;
import org.apache.hadoop.hive.llap.LlapUtil;
import org.apache.hadoop.hive.shims.HadoopShims;
import org.apache.hadoop.hive.shims.ShimLoader;
+import org.apache.hadoop.security.Credentials;
import org.apache.hadoop.security.UserGroupInformation;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
/** No Java application is complete until it has a FactoryFactory. */
public class LlapUgiFactoryFactory {
Review Comment:
@abstractdog, how about
````
LlapUgiManager {
private ConcurrentHashMap<Identifier, UserGroupInformation > fsTaskUgiMap;
private UgiFactory fsUgiFactory;
public LlapUgiManager getInstance(Configuration conf) {
return new LlapUgiManager(conf);
}
private LlapUgiManager(Configuration conf){
try {
fsUgiFactory = LlapUgiFactoryFactory.createFsUgiFactory(daemonConf);
} catch (IOException e) {
throw new RuntimeException(e);
}
}
public UserGroupInformation createUgi(QueryIdentifier queryIdentifier,
String user, Credentials credentials) {
return fsTaskUgiMap.computeIfAbsent(queryIdentifier,
k -> fsUgiFactory.createUgi(k, user, credentials))
}
public void closeAllForUgi(QueryIdentifier queryIdentifier) {
....
fsTaskUgiMap.remove(queryIdentifier);
}
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
