deniskuzZ commented on code in PR #5450:
URL: https://github.com/apache/hive/pull/5450#discussion_r1762514912
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/rewrite/sql/MultiInsertSqlGenerator.java:
##########
@@ -155,22 +156,22 @@ public void appendPartColsOfTargetTableWithComma(String
alias) {
return;
}
queryStr.append(',');
- appendCols(targetTable.getPartCols(), alias, null);
+ appendCols(targetTable.getPartCols(), alias, null, FieldSchema::getName);
}
public void appendAllColsOfTargetTable(String prefix) {
- appendCols(targetTable.getAllCols(), null, prefix);
+ appendCols(targetTable.getAllCols(), null, prefix, FieldSchema::getName);
}
public void appendAllColsOfTargetTable() {
- appendCols(targetTable.getAllCols());
+ appendCols(targetTable.getAllCols(), FieldSchema::getName);
}
-
- public void appendCols(List<FieldSchema> columns) {
- appendCols(columns, null, null);
+
+ public <T> void appendCols(List<T> columns, Function<T, String> func) {
+ appendCols(columns, null, null, func);
}
- public void appendCols(List<FieldSchema> columns, String alias, String
prefix) {
+ public <T> void appendCols(List<T> columns, String alias, String prefix,
Function<T, String> func) {
Review Comment:
renamed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
