KiranVelumuri commented on code in PR #5012:
URL: https://github.com/apache/hive/pull/5012#discussion_r1771078123
##########
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/utils/TestMetaStoreUtils.java:
##########
@@ -82,8 +83,9 @@ public void testDateToString() {
@Test
public void testTimestampToString() {
- assertEquals(timestamp,
MetaStoreUtils.convertTimestampToString(Timestamp.valueOf(timestamp)));
- }
+ String expectedTimestampString = ZonedDateTime.parse(timestamp,
FORMATTER.withZone(ZoneId.systemDefault())).format(FORMATTER);
+ assertEquals(expectedTimestampString,
MetaStoreUtils.convertTimestampToString(Timestamp.valueOf(timestamp)));
// In jdk17, Timestamp makes use of daylight savings which
+ }
// needs to be
incorporated in expectedString too
Review Comment:
Please refer to
[HIVE-28377](https://github.com/apache/hive/commit/e31811bb7c6670ab1f725adde3aa2b012ca64415)
for the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
