deniskuzZ commented on code in PR #5461:
URL: https://github.com/apache/hive/pull/5461#discussion_r1773236202
##########
ql/src/java/org/apache/hadoop/hive/ql/io/HiveSequenceFileInputFormat.java:
##########
@@ -44,20 +44,20 @@ public HiveSequenceFileInputFormat() {
setMinSplitSize(SequenceFile.SYNC_INTERVAL);
}
- private Set<FileStatus> fileStatuses = null;
+ private ThreadLocal<Set<FileStatus>> fileStatuses = new ThreadLocal<>();
Review Comment:
````
public class HiveSequenceFileInputFormat<K extends LongWritable, V extends
BytesRefArrayWritable>
extends SequenceFileInputFormat<K, V> {
private static final ThreadLocal<Set<FileStatus>> fileStatuses = new
ThreadLocal<>();
public HiveSequenceFileInputFormat() {
setMinSplitSize(SequenceFile.SYNC_INTERVAL);
}
public void setFiles(Set<FileStatus> files) {
fileStatuses.set(files);
}
@Override
protected FileStatus[] listStatus(JobConf job) throws IOException {
try {
if (CollectionUtils.isEmpty(fileStatuses.get())) {
// In cases where list of files to fetch is not provided we will use
SequenceFileInputFormat
// e.g. SELECT without a job
return super.listStatus(job);
}
return fileStatuses.get().toArray(new FileStatus[0]);
} finally {
fileStatuses.remove();
}
}
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
