deniskuzZ commented on code in PR #5467:
URL: https://github.com/apache/hive/pull/5467#discussion_r1778326252
##########
iceberg/iceberg-handler/src/test/queries/positive/merge_iceberg_copy_on_write_partitioned.q:
##########
@@ -7,8 +7,8 @@ drop table if exists source;
create external table target_ice(a int, b string, c int) partitioned by spec
(bucket(16, a), truncate(3, b)) stored by iceberg tblproperties
('format-version'='2', 'write.merge.mode'='copy-on-write');
create table source(a int, b string, c int);
-insert into target_ice values (1, 'one', 50), (2, 'two', 51), (111, 'one',
55), (333, 'two', 56);
-insert into source values (1, 'one', 50), (2, 'two', 51), (3, 'three', 52),
(4, 'four', 53), (5, 'five', 54), (111, 'one', 55);
+insert into target_ice values (1, 'match', 50), (2, 'not match', 51), (3,
'delete', 55), (4, 'not delete null', null), (null, 'match null', 56);
Review Comment:
`when matched and t.a > 100 THEN DELETE` is never triggered after the change
also why change this test if you've added a separate for null check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
