zhangbutao commented on code in PR #5215:
URL: https://github.com/apache/hive/pull/5215#discussion_r1796510428
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -2173,4 +2179,32 @@ public List<FileStatus>
getMergeTaskInputFiles(Properties properties) throws IOE
public MergeTaskProperties getMergeTaskProperties(Properties properties) {
return new IcebergMergeTaskProperties(properties);
}
+
+ private Snapshot
getSpecificSnapshot(org.apache.hadoop.hive.ql.metadata.Table hmsTable, Table
table) {
Review Comment:
Moved this function into IcebergTableUtil.
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java:
##########
@@ -457,9 +457,11 @@ public static Path getDumpPath(Path root, String dbName,
String tableName) {
}
public static String getTableSnapshotRef(String refName) {
- Matcher ref = SNAPSHOT_REF.matcher(refName);
- if (ref.matches()) {
- return ref.group(1);
+ if (refName != null && !refName.isEmpty()) {
Review Comment:
Fixed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
