okumin commented on code in PR #5452:
URL: https://github.com/apache/hive/pull/5452#discussion_r1804682071
##########
ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/PlanMapper.java:
##########
@@ -32,21 +32,34 @@
import java.util.Objects;
import java.util.Set;
+import java.util.concurrent.atomic.AtomicBoolean;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.apache.hadoop.hive.conf.HiveConf.ConfVars;
import org.apache.hadoop.hive.ql.exec.Operator;
import org.apache.hadoop.hive.ql.optimizer.signature.OpTreeSignature;
import org.apache.hadoop.hive.ql.optimizer.signature.OpTreeSignatureFactory;
import com.google.common.annotations.VisibleForTesting;
import com.google.common.collect.Sets;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
/**
* Enables to connect related objects to eachother.
*
* Most importantly it aids to connect Operators to OperatorStats and probably
RelNodes.
*/
public class PlanMapper {
+ private static final Logger LOG = LoggerFactory.getLogger(PlanMapper.class);
- Set<EquivGroup> groups = new HashSet<>();
- private Map<Object, EquivGroup> objectMap = new
CompositeMap<>(OpTreeSignature.class, AuxOpTreeSignature.class);
+ private final Set<EquivGroup> groups = new HashSet<>();
+ private final Map<Object, EquivGroup> objectMap = new
CompositeMap<>(OpTreeSignature.class, AuxOpTreeSignature.class);
+ private final boolean failsWithIllegalLink;
+ private final AtomicBoolean isBroken = new AtomicBoolean(false);
Review Comment:
I lost my memory but I also think we have no reasons to make only this
variable thread-safe. I will make it a primitive boolean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
