deniskuzZ commented on code in PR #5498:
URL: https://github.com/apache/hive/pull/5498#discussion_r1815414460
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -425,6 +426,16 @@ public boolean canProvideBasicStatistics() {
return true;
}
+ @Override
+ public boolean
canProvidePartitionStatistics(org.apache.hadoop.hive.ql.metadata.Table
hmsTable) {
+ Table table = IcebergTableUtil.getTable(conf, hmsTable.getTTable());
+ if (table.currentSnapshot() != null) {
Review Comment:
@zhangbutao thanks for checking. I am again stepping on
https://github.com/apache/hive/pull/5215
Could you please address the review comments so we can merge it and reuse
here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
