difin opened a new pull request, #5520:
URL: https://github.com/apache/hive/pull/5520
…d-users
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA:
https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other
DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
1. Change `'hive.server2.logging.operation.level'` to 'NONE' by default to
hide exception stack traces from end-users.
2. Add query id to HiveSQLException's message when the operational log is
disabled or when its level = 'NONE' or when
`'hive.server2.async.exec.async.compile' `= 'true', because in all these cases
the operational log is not displayed and therefore a query id is also not
displayed. Using query id more info can easily be retrieved from Hiveserver2
log.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
3. If you fix a bug, you can clarify why it is a bug.
-->
**Background**:
Hive operational log is a query log that contains messages for a specific
query id and is intended for Hive clients.
When operational log is enabled, it shows query id, exception stack traces
and other messages in Hue and Beeline (see screenshot attached). Hive clients
fetch the operational log using Hive-specific jdbc method
`HiveStatement.getQueryLog`.
The following settings control operational log behavior:
`Hive.server2.logging.operation.enabled`: true/false (true by default)
`hive.server2.logging.operation.level`:
NONE: Ignore any logging
EXECUTION: Log completion of tasks
PERFORMANCE: Execution + Performance logs
VERBOSE: All logs
Log level can be changed on session level.
The default log level is EXECUTION, which displays exception stack traces
which is not good as a default for non-technical users.
**Problem Description**:
Currently, when `'hive.server2.async.exec.async.compile' = 'true' `and an
exception happens, an operational log is not displayed in Beeline and Hue
(because stmtHandle is empty) and only exception message is displayed. Query id
is not displayed.
When `'hive.server2.async.exec.async.compile' = 'false'` and operational log
level != 'NONE', operational log is displayed with query id and exception stack
trace and also exception message is displayed.
End-users do not need to see exception stack traces by default, but when a
query fails they should know Query ID, because using one they can find stack
traces and other info in HiveServer2 log.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description, screenshot and/or a reproducable
example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### Is the change a dependency upgrade?
<!--
If yes, please attach a file with output from mvn dependency:tree to
validate a complete upgrade of dependency.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
-->
Added new JDBC and Beeline integration tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
