difin commented on code in PR #5522:
URL: https://github.com/apache/hive/pull/5522#discussion_r1820915684
##########
ql/src/java/org/apache/hadoop/hive/ql/plan/LoadFileDesc.java:
##########
@@ -152,4 +153,12 @@ public String getMoveTaskId() {
public void setMoveTaskId(String moveTaskId) {
this.moveTaskId = moveTaskId;
}
+
+ public boolean getIsOverwrite() {
+ return isOverwrite;
+ }
+
+ public void setIsOverwrite(boolean isOverwrite) {
+ this.isOverwrite = isOverwrite;
+ }
Review Comment:
It is better to name the getters/setters for boolean members like
`getOverwrite()` and `setOverwrite`.
https://stackoverflow.com/questions/5322648/for-a-boolean-field-what-is-the-naming-convention-for-its-getter-setter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
