soumyakanti3578 commented on code in PR #5196:
URL: https://github.com/apache/hive/pull/5196#discussion_r1826181683
##########
ql/src/test/results/clientpositive/llap/external_jdbc_table2.q.out:
##########
@@ -713,16 +713,21 @@ STAGE PLANS:
TableScan
alias: p
properties:
- hive.sql.query SELECT "ikey"
+ hive.sql.query SELECT "ikey", "bkey", "fkey", "dkey"
FROM "EXTERNAL_JDBC_SIMPLE_DERBY2_TABLE1"
-WHERE ("bkey" = 10 AND "dkey" = 15.15 OR "bkey" = 20 AND "dkey" = 25.25) AND
"bkey" IN (10, 20) AND ("dkey" IN (15.15, 25.25) AND "ikey" IS NOT NULL)
Review Comment:
This is failing because `SEARCH` operator is not white-listed in
`sqlDialect.supportsFunction`, so it fails in `JDBCRexCallValidator.java`.
Also, I couldn't find any support for `SEARCH` in JdbcRules. Ideally, this
operator should be white-listed and then all `SEARCH` nodes should be expanded
(since jdbc engines might not support it) in all the `convert` methods in
`Jdbc*Rule` classes in Calcite.
For now, we might have to handle it in Hive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
