KiranVelumuri commented on PR #5036: URL: https://github.com/apache/hive/pull/5036#issuecomment-2453508277
> @KiranVelumuri, @okumin sorry for the late jump-in, I overlooked that PR. Changes look good to me, however, I have 1 concern regarding the location of the proto events - it's fixed in sys tables after the schema initialization. What if the end-user decides to change it? Should we move these configs to the hidden / restricted lists? > > Also, could we add a qtest that generates the events and then output the `select * from` the new tables? Thank you @deniskuzZ for the review. The table location was based on the location of protologging events, which is in the sys db. This was done in order to standardise the table location for it to be consistent across versions. In my opinion, these tables' location in db is not meant to be changed by the end user, but instead query from it. The other option available was in INFORMATION_SCHEMA, but SYS db seems appropriate. I will work on adding the related qtest you mentioned. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
