shivjha30 commented on code in PR #5515:
URL: https://github.com/apache/hive/pull/5515#discussion_r1827236443
##########
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java:
##########
@@ -384,7 +384,7 @@ public static PrimitiveTypeEntry
getTypeEntryFromPrimitiveWritableClass(
* Get the TypeEntry for the given base type name (int, varchar, etc).
*/
public static PrimitiveTypeEntry getTypeEntryFromTypeName(String typeName) {
- return typeNameToTypeEntry.get(typeName);
+ return typeNameToTypeEntry.get(typeName.toLowerCase());
Review Comment:
@difin Thanks for the review
Yes, adding return typeNameToTypeEntry.get(typeName.toLowerCase()); is fine.
This ensures that the type name is always treated in lowercase, which is
consistent with how the types are registered in the typeNameToTypeEntry map.
<img width="1049" alt="image"
src="https://github.com/user-attachments/assets/a2f7fd28-b3b6-4e32-a7ba-80b1b223b642";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
