abstractdog commented on code in PR #5530:
URL: https://github.com/apache/hive/pull/5530#discussion_r1830960684


##########
ql/src/test/org/apache/hadoop/hive/ql/exec/TestGetPartitionAuthWithBatches.java:
##########
@@ -50,6 +54,12 @@
 
 public class TestGetPartitionAuthWithBatches {
 
+    @ClassRule
+    public static HiveTestEnvSetup env_setup = new HiveTestEnvSetup();
+
+    @Rule
+    public TestRule methodRule = env_setup.getMethodRule();
+

Review Comment:
   while implementing since 
[HIVE-27972](https://issues.apache.org/jira/browse/HIVE-27972) I realized that 
this kind of boilerplate can be avoided by using a well-prepared hive conf, 
like:
   ```
   new HiveConfForTest(getClass())
   ```
   could this be used here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to