abstractdog commented on code in PR #5535:
URL: https://github.com/apache/hive/pull/5535#discussion_r1837692855
##########
ql/src/java/org/apache/hadoop/hive/ql/QueryInfo.java:
##########
@@ -32,6 +42,7 @@ public class QueryInfo {
private Long endTime;
private String state;
private QueryDisplay queryDisplay;
+ private QueryPlan queryPlan;
Review Comment:
agree, but only because of memory reasons
be aware that counters like this are only available after finishing the DAG
(when it's aggregated in the AM), so including this in the scope of OTEL looks
strange, as this metrics collection is supposed to be a live thing (while
running the query)
I guess if we run this code on a cluster while running a query, it will
return NPE somewhere, or non-sense counter values
I think for proper metrics users should refer to the query history when its
implementation is done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
