abstractdog commented on PR #5537: URL: https://github.com/apache/hive/pull/5537#issuecomment-2470702775
> > It seems to me that this could be done with fewer code changes, however, I could be completely wrong, but to be safe I think we should ask review from @kasakrisz can't we pass the needed flags from the rootQB to qb? > > I was thinking about the same there are flags that should not change across the different levels, like the one that this patch is about: isInsertOverwriteDir if it's set once, it applies to the whole query theoretically: there is no such thing as "some query blocks suggest that the query is IOWD, while others don't" how to implement this properly in this SemanticAnalyzer monster...is a completely different question :D open to ideas > > I believe the worst thing that's currently happening is this: > > https://github.com/apache/hive/blob/e48cb8e986ec254eb44dff684659dcdb8bf118e8/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java#L12435 > > > a field variable is changed while running a recursive method, with all due respect, but without knowing the context, this looks awful :( > however, I wasn't brave enough to touch it for the sake of this fix wait, maybe I have to revise what I said ``` Operator<?> operator = genPlan(qb, qbexpr); ``` looks like the original qb is passed to the method, so I can reuse it, let me try :D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
