difin commented on code in PR #5529:
URL: https://github.com/apache/hive/pull/5529#discussion_r1843017265
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/compact/AlterTableCompactOperation.java:
##########
@@ -118,6 +118,13 @@ else if (desc.getPartitionSpec() != null) {
Optional<String> partitionName =
partitionMap.keySet().stream().findFirst();
partitionName.ifPresent(compactionRequest::setPartitionname);
}
+ if (table.getStorageHandler() != null &&
+ !table.getStorageHandler().canCompact(context.getConf(), table,
compactionRequest.getPartitionname(),
+ compactionRequest.getType())) {
+ LOG.info("Table=%s%s doesn't meet requirements for compaction",
table.getTableName(),
Review Comment:
I removed logging from this place and instead added it to
`HiveIcebergStorageHandler#canCompact`.
This way it will log the exact reason why a table/partition doesn't meet
compaction requirements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
