deniskuzZ commented on PR #5548:
URL: https://github.com/apache/hive/pull/5548#issuecomment-2481387797

   > > This method is not even called upstream!
   > 
   > I'm sorry, I do not understand which method is not called upstream? close 
or filterBatch?
   
   CloseableIterator#close(). Instead CloseableIterable#close is invoked. 
   I've refactored the IcebergRecordReader#nextKeyValue not to use iceber's 
`CloseableIterable.concat` and looking into positional-delete readers leak - 
seems to be some race condition in deletes loading. 
   
   I can repro the issue locally, and I do not see how proposed change even 
supposed to help. `deleteInputIterable` is just a closeable wrapper over 
`srcIterator`, and `deleteOutputIterable` is the result of filter transform on 
the same `srcIterator`. Closing `srcIterator` should be enough to release the 
data-files connection.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to