abstractdog commented on PR #5558: URL: https://github.com/apache/hive/pull/5558#issuecomment-2499869174
> LGTM, I have a minor question since I'm new to IOStatistics. Do we drop `ioStats.gauges()` because Tez does not use it or `gauges()` returns redundant values? thanks for taking a look! in gauges I found things like below: ``` gauges=((stream_write_block_uploads_data_pending=3228222) (stream_write_block_uploads_pending=3584)); ``` they look a bit confusing to aggregate on DAG level: they reflect current state of something on task thread level, that loses its meaning while aggregated on DAG-level (of tasks running on different nodes at different times), let me know if I'm missing something -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
