armitage420 commented on code in PR #5550:
URL: https://github.com/apache/hive/pull/5550#discussion_r1861163710
##########
serde/src/java/org/apache/hadoop/hive/serde2/JsonSerDe.java:
##########
@@ -139,7 +139,6 @@ private void initialize(final Configuration conf, final
Properties tbl,
this.jsonReader = new HiveJsonReader(this.soi, tsParser);
this.jsonWriter = new HiveJsonWriter(this.binaryEncoding,
getColumnNames());
- this.jsonReader.setBinaryEncoding(binaryEncoding);
Review Comment:
@deniskuzZ Thanks for the review again!
Before [HIVE-21240](https://issues.apache.org/jira/browse/HIVE-21240),
RAWSTRING was the default `binaryEncoding,` but it caused serialization issues.
While most of these were addressed with precondition checks, switching to
BASE64 binaryEncoding provides better handling for cases involving, say,
special characters.
Moreover, if we decide to use RAWSTRING again in the future, the change can
be made easily by updating a single variable, ensuring flexibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
