BsoBird commented on code in PR #5562:
URL: https://github.com/apache/hive/pull/5562#discussion_r1861444384
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/mapjoin/MapJoinMemoryExhaustionHandler.java:
##########
@@ -96,7 +96,12 @@ public void checkMemoryStatus(long tableContainerSize, long
numRows)
+ tableContainerSize + "\tMemory usage:\t" + usedMemory +
"\tpercentage:\t" + percentageNumberFormat.format(percentage);
console.printInfo(msg);
if(percentage > maxMemoryUsage) {
- throw new MapJoinMemoryExhaustionError(msg);
+ System.gc();
Review Comment:
I've used this patch in our production environment, and the OOM and
MapJoinMemoryExhaustionError related issues have really been reduced. However,
I do agree with you to some extent that the current implementation is a bit
problematic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
