zhangbutao commented on code in PR #5541: URL: https://github.com/apache/hive/pull/5541#discussion_r1868807159
########## parser/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g: ########## @@ -1840,6 +1841,14 @@ tableImplBuckets -> ^(TOK_ALTERTABLE_BUCKETS $num) ; +tableWriteOrdered +@init { pushMsg("table sorted specification", state); } +@after { popMsg(state); } + : + KW_WRITE KW_ORDERED KW_BY sortCols=columnNameOrderList Review Comment: Does this syntax equal to Spark-Iceberg ` alter-table-write-ordered-by`? https://iceberg.apache.org/docs/1.7.0/spark-ddl/#alter-table-write-ordered-by Do you consider also to add the ` alter-table-write-ordered-by` syntax? So that user can alter the existing iceberg table to support write order. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org