deniskuzZ commented on code in PR #5559: URL: https://github.com/apache/hive/pull/5559#discussion_r1871583131
########## ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommands3.java: ########## @@ -91,8 +91,8 @@ public void testRenameTable() throws Exception { "s/delta_0000001_0000001_0000/bucket_00000_0"}, {"{\"writeid\":2,\"bucketid\":536870913,\"rowid\":0}\t4\t6", "s/delta_0000002_0000002_0001/bucket_00000_0"}}; - checkResult(expected, testQuery, false, "check data", LOG); - + List<String> rs = runStatementOnDriver(testQuery); Review Comment: should the `checkResult` run the query and do the validation? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org