okumin commented on PR #5556: URL: https://github.com/apache/hive/pull/5556#issuecomment-2525063095
@yiqijiu > Thank you for your patient guidance No problem at all. Our documents are obviously a bit obsolete. I will initiate the discussion to refine them. The test case looks great. We would have some requests. ### 1. Can we keep only explain_big_table_multiple_ptf_2.q? I guess `explain_big_table_multiple_ptf_2.q` can cover `explain_big_table_multiple_ptf.q`. I understand the two cases have slightly different conditions, and it would usually make sense to keep both. However, the mechanism of our qtest is a little time and resource consuming of Jenkins. So, we would like to keep the minimal set of test cases. In short, we may rename `explain_big_table_multiple_ptf_2.q` into `explain_big_table_multiple_ptf.q`, which means the original content of `explain_big_table_multiple_ptf.q` will be removed. Please let us know if we have a valid reason to keep both. ### 2. Can we use TestMiniLlapLocalCliDriver? The current output is written in `ql/src/test/results/clientpositive/explain_big_table_multiple_ptf.q.out`. I guess you used `-Dtest=TestCliDriver` or something else. Currently, our Jenkins does regression tests using `TestMiniLlapLocalCliDriver` by default. That's why CI is failing. In short, could you please rerun `mvn test -Dtest=TestMiniLlapLocalCliDriver -Dqfile=explain_big_table_multiple_ptf.q -Dtest.output.overwrite=true`? It will generate `ql/src/test/results/clientpositive/llap/explain_big_table_multiple_ptf.q.out`, where you will see `llap` in the middle of the path. Please also delete `ql/src/test/results/clientpositive/explain_big_table_multiple_ptf.q.out` and `ql/src/test/results/clientpositive/explain_big_table_multiple_ptf_2.q.out`. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
