okumin commented on code in PR #5556:
URL: https://github.com/apache/hive/pull/5556#discussion_r1875147777
##########
ql/src/test/queries/clientpositive/explain_big_table_multiple_ptf.q:
##########
@@ -0,0 +1,31 @@
+create table explain_multiple_ptf_big_table
+(
+ key1 string,
+ value_str1 string,
+ key3 string
+);
+create table explain_multiple_ptf_big_table2
+(
+ key21 string,
+ value_str21 string,
+ key23 string
+);
+alter table explain_multiple_ptf_big_table
+ update statistics set('numRows' = '4611686036854775807',
+ 'rawDataSize' = '922337203685477500');
+alter table explain_multiple_ptf_big_table2
+ update statistics set('numRows' = '4611686036854775807',
+ 'rawDataSize' = '9223372036854775800');
+explain
+select *,row_number() over (partition by key order by key2 desc) rn,
+ row_number() over (partition by key2 order by key desc) rn2,
+ max(value_str) over (partition by key2 order by key desc) max1,
+ max(value_str) over (partition by key order by key2 desc) max3,
+ min(value_str) over (partition by key2 order by key desc) min1,
+ min(value_str) over (partition by key order by key2 desc) min3,
+ last_value(value_str) over (partition by key) lv,
+ first_value(value_str) over (partition by key2) fv,
+ max(value_str) over (partition by key) fv21
+from (select key1 key, value_str1 value_str, key3 key2 from
explain_multiple_ptf_big_table
+union all select key21 key, value_str21 value_str, key23 key2 from
explain_multiple_ptf_big_table2) a1
+;
Review Comment:
No problem at all. I am aware that it is tricky how qtest works.
The last thing is, maybe some of your scripts removed extra spaces when you
committed the change. `qtest` requires any bytes equal to the expected bytes,
which means we have to keep any characters on `*.q.out` as it is.
```
[2024-12-08T19:16:46.814Z] < Map 1
[2024-12-08T19:16:46.814Z] ---
[2024-12-08T19:16:46.814Z] > Map 1
[2024-12-08T19:16:46.814Z] 137c137
[2024-12-08T19:16:46.814Z] < Map 8
[2024-12-08T19:16:46.814Z] ---
[2024-12-08T19:16:46.814Z] > Map 8
[2024-12-08T19:16:46.814Z] 155c155
[2024-12-08T19:16:46.814Z] < Reducer 3
[2024-12-08T19:16:46.814Z] ---
[2024-12-08T19:16:46.814Z] > Reducer 3
[2024-12-08T19:16:46.814Z] 205c205
[2024-12-08T19:16:46.814Z] < Reducer 4
[2024-12-08T19:16:46.814Z] ---
[2024-12-08T19:16:46.814Z] > Reducer 4
[2024-12-08T19:16:46.814Z] 255c255
[2024-12-08T19:16:46.814Z] < Reducer 5
[2024-12-08T19:16:46.814Z] ---
[2024-12-08T19:16:46.814Z] > Reducer 5
[2024-12-08T19:16:46.814Z] 293c293
[2024-12-08T19:16:46.814Z] < Reducer 6
[2024-12-08T19:16:46.814Z] ---
[2024-12-08T19:16:46.814Z] > Reducer 6
[2024-12-08T19:16:46.814Z] 331c331
[2024-12-08T19:16:46.814Z] < Reducer 7
[2024-12-08T19:16:46.814Z] ---
[2024-12-08T19:16:46.814Z] > Reducer 7
[2024-12-08T19:16:46.814Z] 369c369
[2024-12-08T19:16:46.814Z] < Union 2
[2024-12-08T19:16:46.814Z] ---
[2024-12-08T19:16:46.814Z] > Union 2
```
If it is hard to resolve, you may edit the `q.out` by hand and add spaces.
You can test it in your environment using `mvn test
-Dtest=TestMiniLlapLocalCliDriver -Dqfile=explain_multiple_ptf_on_big_table.q`.
Without `-Dtest.output.overwrite=true`, it works in the same way of Jenkins.
That means if the actual result is inconsistent with
`explain_multiple_ptf_on_big_table.q.out`, it fails.
My recommended steps.
1. Run `mvn test -Dtest=TestMiniLlapLocalCliDriver
-Dqfile=explain_multiple_ptf_on_big_table.q` in the current revision and
confirms that it surely fails. If it succeeds, maybe you are executing the
command in a wrong way
2. Edit
`ql/src/test/results/clientpositive/llap/explain_big_table_multiple_ptf.q.out`
by hand, or rerun `mvn test -Dtest=TestMiniLlapLocalCliDriver
-Dqfile=explain_multiple_ptf_on_big_table.q -Dtest.output.overwrite=true`
3. Commit and finalize the change before something updates
`ql/src/test/results/clientpositive/llap/explain_big_table_multiple_ptf.q.out`
4. Run `mvn test -Dtest=TestMiniLlapLocalCliDriver
-Dqfile=explain_multiple_ptf_on_big_table.q` again and confirm it succeeds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
