kasakrisz commented on code in PR #5505:
URL: https://github.com/apache/hive/pull/5505#discussion_r1875977861
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java:
##########
@@ -5611,4 +5365,282 @@ private enum TableType {
JDBC
}
+ class OrderByRelBuilder {
Review Comment:
I made the class private. Unfortunately this is a non-static inner class. It
would be better to make it static or move it to a new file but it references
methods like `CalcitePlannerAction.genAllRexNode`.
So the methods and the fields are accessible from the `CalcitePlannerAction`
instance even if they are declared as private.
I tried to set methods and fields as `private` which should not be accessed
outside the class and make `package private` the methods which should be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
